Magnus Hagander wrote:
On Wed, Aug 01, 2007 at 11:17:21AM +0900, Hiroshi Saito wrote:
"Hiroshi Saito" <[EMAIL PROTECTED]> writes:
[ patch to use pg_strftime in xlog.c ]
This code deliberately does not use pg_strftime, for the same reasons
that elog.c doesn't use it.

I'm inclined to think that an appropriate fix is the same as we use in
elog.c, ie, don't use %Z at all under Windows.
Eh? Do you mean this change? "%Y-%m-%d %H:%M:%S %Z" to "%Y-%m-%d %H:%M:%S"
That tzname is expressed here does not regard me as a problem.
Probably, elog.c has still more nearly another problem.

Having talked a bit off-list with Hiroshi-san, he came up with the
suggestion taht we should be logging this information in UTC/GMT instead of
the servers timezone (for all cases, not just win32). That would make
things equally "safe" wrt changes in the pg timezone, and always
Thoughts on this?

Are you just talking about xlog.c? That wouldn't be an acceptable change in elog.c, although we could provide additional escapes to output UTC if needed.



---------------------------(end of broadcast)---------------------------
TIP 9: In versions below 8.0, the planner will ignore your desire to
      choose an index scan if your joining column's datatypes do not

Reply via email to