Heikki Linnakangas wrote: > BTW, the encoding of the XML datatype looks pretty funky. xml_recv first > reads the xml string with pq_getmsgtext, which applies a client->server > conversion. Then the xml declaration is parsed, extracting the encoding > attribute. Then the string is converted again from that encoding (or > UTF-8 if none was specified) to server encoding. I don't understand how > it's supposed to work, but ISTM there's one conversion too much,
And it's got an unfortunate typo in it as well: it calls "free(result)" instead of pfree. I think we need regression tests for the more complex send/recv functions... What's the difference between text and binary mode for something like xml anyway? Could we just call the text format in/out functions and be done with it? -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com ---------------------------(end of broadcast)--------------------------- TIP 2: Don't 'kill -9' the postmaster
