Jorgen Austvik - Sun Norway wrote: > Tom Lane wrote: >> Jorgen Austvik - Sun Norway <[EMAIL PROTECTED]> writes: >>> I believe the results paths in line 139 and 144 are missing the >>> @abs_builddir@ qualifier. >> I'd put it the other way around: likely we should get rid of the >> one use of @[EMAIL PROTECTED] > > He, he. > > Generally I prefer explicit over implicit (having the full paths make > troubleshooting easier), but in this case you have the additional aspect of > the lo_import operating relative to the client, while lo_export operates > relative to the server.
I submit that the test is OK as it currently is. The lo_export() call is expanded by the server, which can be running anywhere -- hence the need to use an absolute path. Then we have \lo_import and \lo_export calls which are relative to the client. The client is already running in the regress builddir, so using relative paths works fine. If I try to run the client from another directory, it fails completely. Exactly what is the problem you are trying to fix? $ cd .. $ pwd /pgsql/build/00head/src/test $ regress/pg_regress largeobject (using postmaster on Unix socket, port 55432) ============== dropping database "regression" ============== DROP DATABASE ============== creating database "regression" ============== CREATE DATABASE ALTER DATABASE ============== running regression test queries ============== test largeobject ... /bin/sh: cannot open ./sql/largeobject.sql: No such file diff: ./expected/largeobject.out: No such file or directory diff: ./results/largeobject.out: No such file or directory diff command failed with status 512: diff -w "./expected/largeobject.out" "./results/largeobject.out" > "./results/largeobject.out.diff" -- Alvaro Herrera http://www.advogato.org/person/alvherre "The Postgresql hackers have what I call a "NASA space shot" mentality. Quite refreshing in a world of "weekend drag racer" developers." (Scott Marlowe) ---------------------------(end of broadcast)--------------------------- TIP 2: Don't 'kill -9' the postmaster
