Thanks for reviewing the patch. Please go ahead and make the changes and re-submit the patch. I will take care, that i won't repeat the stated mistakes again.
The Missing of Thick Keyword - i don't know how it got removed. Thanks, Gokul On Jan 23, 2008 10:49 PM, Jonah H. Harris <[EMAIL PROTECTED]> wrote: > On Jan 23, 2008 11:28 AM, Gokulakannan Somasundaram <[EMAIL PROTECTED]> > wrote: > > Fixed a type 'o'.... > > I'm playing with this now against 8.3 HEAD. Looks like there's a > couple things which are problematic: > > - DefineIndex was updated only in bootparse.c, not in bootparse.y > - The patch contains changes to pg_config.h > - THICK isn't defined in gram.y (as a token or under > unreserved_keywords), so compilation of keywords.c fails. > > In the future, please make changes to the proper pre-built files so > that someone doesn't have to configure it, then patch it. I have them > fixed and will submit the patch back here if you'd like. Or, you can > fix it. It's up to you :) > > -- > Jonah H. Harris, Sr. Software Architect | phone: 732.331.1324 > EnterpriseDB Corporation | fax: 732.331.1301 > 499 Thornall Street, 2nd Floor | [EMAIL PROTECTED] > Edison, NJ 08837 | http://www.enterprisedb.com/ >
