Alvaro Herrera írta:
I don't think my $int64passbyval = "(?($real64 = 1)t|f)";works. Perhaps my $int64passbyval = $real64 ? 't' : 'f';
Thanks. Modified patch attached. Stupid question follows. Now that float4 is passed by value unconditionally, is it worth modifying the *penalty() functions in GIST/TSearch to just use PG_RETURN_FLOAT4()? Or the implicit "modify the float4 value at the caller site and return the same pointer I got as 3rd parameter" is an internal API set in stone? Modifying them to have only 2 parameters (the 3rd one was an implicit OUT parameter anyway) and omitting the pointer dereference might give a small speedup. -- ---------------------------------- Zoltán Böszörményi Cybertec Schönig & Schönig GmbH http://www.postgresql.at/
pg84-passedbyval-v5.patch.gz
Description: Unix tar archive
-- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches
