Brendan Jurd escribió: > I'd like to submit my first version of this patch for review. I have > introduced a new struct in print.h called printTableContent, which is > used to compose the contents of a psql table. The methods exposed for > this struct are as follows:
Looks cool -- on a first read, I think you should add some more code comments at the top of each function specifying whether the texts need to be translated by the caller or done by the function itself. Also it would be good if it is consistent, too :-) -- Alvaro Herrera http://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches
