Hi guys,

Here's the latest version of the printTable API.  This version is
against the current HEAD and merges in the changes made by the
recently committed psql wrap patch.

This version also includes Alvaro's fix for the issue of pg_strdup not
being available to programs in scripts/ (as quoted below).

Clean compile and all regression tests passed on amd64 gentoo.


On Thu, May 8, 2008 at 7:55 AM, Alvaro Herrera
> FWIW I just noticed something else.  With this patch we add pg_strdup
> calls into print.c.  pg_strdup lives in common.c.
> This is fine as psql is concerned, but we have another problem which is
> that in bin/scripts there are two programs that want to use
> printQuery().  The problem is that there's no pg_strdup there :-(
> The easy solution is to add pg_strdup to bin/scripts/common.c, but there
> we don't have a global progname, so the error report in the out of
> memory case cannot carry the name of the program crashing.
> I don't like that, but I don't see any other solution.  Ideas welcome.
> --
> Alvaro Herrera                                http://www.CommandPrompt.com/
> PostgreSQL Replication, Consulting, Custom Development, 24x7 support

Attachment: print-table-5.diff.bz2
Description: BZip2 compressed data

Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org)
To make changes to your subscription:

Reply via email to