please, go ahead :) On 24 Jul 2014, at 10:23, Nicolai Hess <[email protected]> wrote:
> If no one raises objections, I would like to start on refactor / cleanup > nautilus code. > > This includes: > > renaming / recategorizing > solve code critics shown in Critics Browser > split classes (AbstractNautilusUI has 427 methods 24 instvars ) > stronger separation between the browser model, browser state > and browser UI. > > review event handling and UI updating > (sometimes there is a difference between what the UI shows > as selected and the selection the model(s) holds > > maybe: > create one package pane widget for package and groups > (therefore move all that package vs groups handling from > nautilus ui to that widget) > merge Nautilus and PackageTreeNautilus > > (I don't consider all of Nautilus bad code, it has well > designed parts, it just has grown meanwhile...) > > How to update the code? > > Working with slices makes it easier to find changes > that introduces new bugs. > Otherwise it takes time to do it in such small steps and I don't > know if those changes are reviewed at all. > > So, I would try to group the changes. > 1. code critics > 2. renameing/ simple refactoring > 3. .... > > > nicolai > > >
