2014-07-24 10:28 GMT+02:00 Baptiste Quide <[email protected]>: > Good luck for that. > I will have a look because the tool which allows to watch package > dependencies embeds the Nautilus Browser, and i'm one of the maintainer at > this time. >
Good to know! > > Baptiste > > ------------------------------ > > *De: *"Nicolai Hess" <[email protected]> > *À: *"Pharo Development List" <[email protected]> > *Envoyé: *Jeudi 24 Juillet 2014 10:23:15 > *Objet: *[Pharo-dev] Refactor Nautilus > > > If no one raises objections, I would like to start on refactor / cleanup > nautilus code. > > This includes: > > renaming / recategorizing > solve code critics shown in Critics Browser > split classes (AbstractNautilusUI has 427 methods 24 instvars ) > stronger separation between the browser model, browser state > and browser UI. > > review event handling and UI updating > (sometimes there is a difference between what the UI shows > as selected and the selection the model(s) holds > > maybe: > create one package pane widget for package and groups > (therefore move all that package vs groups handling from > nautilus ui to that widget) > merge Nautilus and PackageTreeNautilus > > (I don't consider all of Nautilus bad code, it has well > designed parts, it just has grown meanwhile...) > > How to update the code? > > Working with slices makes it easier to find changes > that introduces new bugs. > Otherwise it takes time to do it in such small steps and I don't > know if those changes are reviewed at all. > > So, I would try to group the changes. > 1. code critics > 2. renameing/ simple refactoring > 3. .... > > > nicolai > > > > >
