Hi Sean, did you see issue 13229 (https://pharo.fogbugz.com/f/cases/13229/Year-arithmetic-broken)? It adds a new class AnnualDuration to allow for correct year based arithmetics. It also introduces floats for seconds (with nano seconds as base).
I guess that issue and your change will conflict but as I understand it, your change probably does pretty much the same (for the year part at least)? Could you take a look? Cheers, Max On 19.09.2014, at 13:54, Sean P. DeNigris <[email protected]> wrote: > From > http://forum.world.st/Next-version-of-Date-DateAndTime-and-Duration-API-updates-td4778871.html > : > > Now in the InBox: > KernelTests-cbc.278.mcz > Kernel-cbc.871.mcz > The tests add in test for expected Duration addition and subtraction from > each other, including the new GenericMonth and GenericYear, and the very new > GenericDuration. It also adds a few more tests for LeapYear tests with > adding years to them. > > The test are still based on what it currently does, with the exceptions > listed previously (I haven't really changed any to expect failures, as has > been suggested - that will come shortly. For now, I want to try to cause > little to no changes o expected behavior first - just new behavior for now). > > Kernel adds the GenericDuration, and handles adding and subtracting > GenericMonth, GenericYear, and GenericDurations togeher in a rational way. > This involves turning + and - in Durations into a double-dispatch so that it > will work. > > There are no comments yet in these classes - they will be there before the > weekend is over at the latest. > > Any comments are more than welcome. > > -cbc > > > > ----- > Cheers, > Sean > -- > View this message in context: > http://forum.world.st/Interesting-Date-Time-Thread-on-Squeak-Dev-tp4778652p4778945.html > Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com. >
