No class is safe from my wrath he he...

VersionnerRepositoriesManager class>>#open
        | dialog |
        dialog := remotesUI openDialogWithSpec.
        dialog okAction: [  ]

- why were we wiping the okAction? "dialog okAction: [  ]" does not reveal
any intention. At minimum, a comment would be good
- it would be good to return something here so users can customize more
easily. Even though this is tightly integrated with Versionner, a tiny bit
of care makes the system more easily extensible. We should record some
patterns here...



-----
Cheers,
Sean
--
View this message in context: 
http://forum.world.st/VersionnerRepositoriesManager-Why-clear-okAction-tp4786321.html
Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

Reply via email to