Hi Sean,

Le 23 oct. 2014 à 23:16, Sean P. DeNigris a écrit :

> No class is safe from my wrath he he...
> 
> VersionnerRepositoriesManager class>>#open
>       | dialog |
>       dialog := remotesUI openDialogWithSpec.
>       dialog okAction: [  ]
> 
> - why were we wiping the okAction? "dialog okAction: [  ]" does not reveal
> any intention. At minimum, a comment would be good

I fully agree. I wrote the code some months ago and I forgot the reason ...
I think the setting of the okAction is useless.
I often put a comment but i miss this one. Thanks for the feedback.

> - it would be good to return something here so users can customize more
> easily. Even though this is tightly integrated with Versionner, a tiny bit
> of care makes the system more easily extensible. We should record some
> patterns here...

Maybe what you need is RemotesManager. I extracted this component from Komitter.

Attachment: smime.p7s
Description: S/MIME cryptographic signature

Reply via email to