On Tue, Mar 3, 2015 at 3:30 PM, Nicolai Hess <[email protected]> wrote:
> > 2015-03-03 15:14 GMT+01:00 Marcus Denker <[email protected]>: > >> >> On 03 Mar 2015, at 08:06, Marcus Denker <[email protected]> wrote: >> >> >> On 02 Mar 2015, at 18:29, Marcus Denker <[email protected]> wrote: >> >> >> >> Other things TODO to make it even smaller: >> >> - Hunt down that one GTPlayground instance that is hanging around >> >> >> This is *strange*. I was able to get it down to 1 >> >> Smalltalk garbageCollect. >> Smalltalk garbageCollect. >> Smalltalk garbageCollect. >> GTPlayground allInstances size. >> >> and then I saved that and uploaded it the build server. Now all the >> Undeclareds are gone. >> Yet, when I download the last build, open *one* GTPlayground: >> >> GTPlayground allInstances size ==> 2. >> There is something happening that I don’t understand. >> >> >> I think we found it: >> >> >> https://pharo.fogbugz.com/f/cases/15044/GTSpotterGlobalShortcut-class-needs-to-have-cleanUp >> >> Marcus >> > > > Maybe there is another cause: > > "A fresh image that only uses old Workspace" > > Smalltalk garbageCollect. > GTPlayground allInstances size. -> 1 > > > (RubFindReplaceService classVarNamed:#Singleton) whenDialogDeleted. > RubFindReplaceService classVarNamed:#Singleton put:nil > > Smalltalk garbageCollect. > GTPlayground allInstances size. -> 0 > Added a #cleanUp method to RubFindReplaceService Cheers, Andrei > > RubFindReplaceService may nead a cleanUp, too. > The whenDialogDeleted is called on a MorphDeleted announcement, but > somehow this does not work, the method is never called, maybe the > MorphDeleted is never > announced? > > > >
