Hi Guillermo,

I have not found better solution. Waiting without a timeout threshold is not 
nice and makes it difficult to run all tests. 
If you have better idea how to sync and test two processes, I will appreciate 
it. 
Otherwise I will use a higher timeout.

Cheers,
Juraj

> El 11-09-2017, a las 06:55, Guillermo Polito <guillermopol...@gmail.com> 
> escribió:
> 
> Hi Juraj,
> 
> think that it may really depend on the machine and the state of the system. 
> Slower slave machines could not really work with that timeout...
> 
> The question is how could we make such test more robust.
> 
> On Sun, Sep 10, 2017 at 6:41 PM, Juraj Kubelka <juraj.kube...@icloud.com 
> <mailto:juraj.kube...@icloud.com>> wrote:
> Hi,
> 
> I have checked the EventRecorderTests and it works on my computer. The only 
> reason that it might not work on other cases is that there an assert for 
> 'semaphore waitTimeoutMSecs: 200’. I can put higher timeout if necessary. The 
> timeout 200 has worked for couple of years, right?. There might be another 
> issue.
> 
> Cheers,
> Juraj
> 
>> El 10-09-2017, a las 10:13, Guillermo Polito <guillermopol...@gmail.com 
>> <mailto:guillermopol...@gmail.com>> escribió:
>> 
>> Hi all,
>> 
>> Since a couple of builds we have consistently failing the following tests:
>> 
>> GT.EventRecorder.Tests.Core.GTEventRecorderTest.testDeliverNow2 
>> <https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/development/110/testReport/junit/GT.EventRecorder.Tests.Core/GTEventRecorderTest/testDeliverNow2/>
>> GT.EventRecorder.Tests.Core.GTEventRecorderTest.testNotDeliveredDataShouldBeResent
>>  
>> <https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/development/110/testReport/junit/GT.EventRecorder.Tests.Core/GTEventRecorderTest/testNotDeliveredDataShouldBeResent/>
>> Kernel.Tests.Processes.MutexTest.testFailedCriticalSectionShouldUnblockWaitingOne
>>  
>> <https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/development/110/testReport/junit/Kernel.Tests.Processes/MutexTest/testFailedCriticalSectionShouldUnblockWaitingOne/>
>> ReleaseTests.Categorization.ProperMethodCategorizationTest.testHashMethodNeedsToBeInComparingProtocol
>>  
>> <https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/development/110/testReport/junit/ReleaseTests.Categorization/ProperMethodCategorizationTest/testHashMethodNeedsToBeInComparingProtocol/>
>> ReleaseTests.Categorization.ProperMethodCategorizationTest.testHashMethodNeedsToBeInComparingProtocol
>>  
>> <https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/development/110/testReport/junit/ReleaseTests.Categorization/ProperMethodCategorizationTest/testHashMethodNeedsToBeInComparingProtocol_2/>
>> ReleaseTests.Categorization.ProperMethodCategorizationTest.testHashMethodNeedsToBeInComparingProtocol
>>  
>> <https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/development/110/testReport/junit/ReleaseTests.Categorization/ProperMethodCategorizationTest/testHashMethodNeedsToBeInComparingProtocol_3/>
>> ReleaseTests.Categorization.ProperMethodCategorizationTest.testHashMethodNeedsToBeInComparingProtocol
>>  
>> <https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/development/110/testReport/junit/ReleaseTests.Categorization/ProperMethodCategorizationTest/testHashMethodNeedsToBeInComparingProtocol_4/>
>> ReleaseTests.Categorization.ProperMethodCategorizationTest.testHashMethodNeedsToBeInComparingProtocol
>>  
>> <https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/development/110/testReport/junit/ReleaseTests.Categorization/ProperMethodCategorizationTest/testHashMethodNeedsToBeInComparingProtocol_5/>
>> ReleaseTests.Categorization.ProperMethodCategorizationTest.testHashMethodNeedsToBeInComparingProtocol
>>  
>> <https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/development/110/testReport/junit/ReleaseTests.Categorization/ProperMethodCategorizationTest/testHashMethodNeedsToBeInComparingProtocol_6/>
>> ReleaseTests.Categorization.ProperMethodCategorizationTest.testHashMethodNeedsToBeInComparingProtocol
>>  
>> <https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/development/110/testReport/junit/ReleaseTests.Categorization/ProperMethodCategorizationTest/testHashMethodNeedsToBeInComparingProtocol_7/>
>> 
>> 
>> Green builds are the only hard metric to say if the build is healthy or not.
>> 
>> - We should not integrate anything until the build is green again...
>> 
>> Also, we spent with Pablo a lot of time to have a green build in all 
>> platforms...  I'd like to spend my time in other fun stuff than the CI :/
>> 
>> -- 
>>    
>> Guille Polito
>> 
>> Research Engineer
>> French National Center for Scientific Research - http://www.cnrs.fr 
>> <http://www.cnrs.fr/>
>> 
>> 
>> Web: http://guillep.github.io <http://guillep.github.io/>
>> Phone: +33 06 52 70 66 13 <tel:+33%206%2052%2070%2066%2013>
> 
> 
> 
> -- 
>    
> Guille Polito
> 
> Research Engineer
> French National Center for Scientific Research - http://www.cnrs.fr 
> <http://www.cnrs.fr/>
> 
> 
> Web: http://guillep.github.io <http://guillep.github.io/>
> Phone: +33 06 52 70 66 13

Reply via email to