On 14 September 2017 at 09:24, Denis Kudriashov <[email protected]> wrote: > Thank's guys for comments. And thank's Torsten for this initiative. I will > merge your changes soon.
RIGHT. A bit late to the party, but I agree that the right version is much easier to read. Thanks, Alistair > 2017-09-14 7:09 GMT+02:00 Max Leske <[email protected]>: >> >> Right >> >> >> On 13 September 2017 at 18:08:26, Torsten Bergmann ([email protected]) wrote: >> >> Hi all, >> >> as you know Denis Kudriashov does a fantastic job in implementing the new >> Calypso system browser. >> The plan is that at some point in time will be a replacement for Nautilus >> in the standard image. >> Even if not yet integrated one can already use it (either by loading from >> catalog or github [1]) >> >> For me the more I use it (and get used to it) the more I like Calypso and >> I guess others enjoy it too already. >> >> But unfortunately there is a single but very prominently visible UI thing >> that I dislike on the current look: >> >> For the "Pharo3Theme" (light theme) the current implementation of Calypso >> has a white toolbar in the >> middle and a white status bar at the bottom. Technically Dennis sets the >> colors of these morphs to >> transparent to have this effect (see LEFT example of the attached >> screenshot) >> >> >> To me this lookes strange and unusual because >> - usually (on Windows, GTK, Java Swing, Linux window managers) such areas >> like a status bar follow the window color >> and are displayed in gray when that is the default window theme color (see >> [2], [3], [4]) >> - these white bars would better fit for the "Glamorous Whitespace" theme >> (as this theme is already more white areas) >> >> Also the current white bars do not make a pleasant contrast to the other >> panes of Calypso: >> - there is not really a visual distinction to the >> package/class/protocol-tag/method panes and filters for the middle part >> (toolbar) >> - there is not really a visual distinction from the code pane for the >> bottom part (statusbar) >> - the divider line in the code pane just stops in a white area without >> borders >> >> To me this looks rather ugly and I would like Pharo to look more >> professional and clean ;) >> >> So I proposed a simple PR [5] today to change this and technically using >> the window color of the theme - the result can be >> seen on the right side of the attached screenshot and discussed with Denis >> on Discord. >> >> Denis on the other hand still likes the white approach on the left more >> while I prefer the right one. >> >> He wrote that he wants other people comment on this issue first to which I >> agree and therefore I write this mail >> to discuss it here on the dev-list and find out about what the majority in >> the community prefers. >> >> So it would be good if others could >> - comment about their personal preference >> - or just vote with "LEFT" (white/transparent) or "RIGHT" (window color) >> in reply to this mail >> - or make another proposal (which is only accepted with screenshot and PR >> ;) >> >> Also please do not mix other UI discussions into this thread. Thanks in >> advance! >> >> Bye >> T. >> >> [1] https://github.com/dionisiydk/Calypso >> [2] >> http://cdn.osxdaily.com/wp-content/uploads/2011/08/show-status-bar-and-disk-space-lion.jpg >> [3] http://i.stack.imgur.com/pgt5n.png >> [4] http://python.zirael.org/gtk-statusbar1-1.png >> [5] https://github.com/dionisiydk/Calypso/pull/91 > >
