yes, that’s a way. anther way is to use “PR tool” : in menu, choose “GitHub”, then “Review pull requests…”.
You will need your github user/pass since this is using the github api. … and of course, this can be loadable/testable or not, depending on the part of the system you will be loading (it is usually ok). But in general, it should work (I do not think many people has used this tool so it can fail). Esteban > On 5 Feb 2018, at 14:52, [email protected] wrote: > > Hello Sven, > the easy way I found to review an image of the change in a PR is to use > the image from the CI server. > > In > https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/view/change-requests/ > > <https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/view/change-requests/> > you can see all the jobs of the PR (every PR is run in the CI as soon as it > is created or updated). > > There you can find the PR by its number, for example: > > https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/view/change-requests/job/PR-797/ > > <https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/view/change-requests/job/PR-797/> > > And then later you can check the results of the tests or downloading an image > with the changes in Last Successful Artifacts: > > https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/view/change-requests/job/PR-797/ > > <https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/view/change-requests/job/PR-797/> > > The images are inside the folder "bootstrap-cache" and you should take the > Pharo-32bits-****.zip or Pharo-64bits-****.zip. > > Cheers. > > On Mon, Feb 5, 2018 at 1:54 PM, Sven Van Caekenberghe <[email protected] > <mailto:[email protected]>> wrote: > Hi, > > With pull requests, it is relatively easy to see what changed in GitHub. > > Eg. Marcus' latest fix: > > https://github.com/pharo-project/pharo/pull/797 > <https://github.com/pharo-project/pharo/pull/797> > > shows 6 files/classes changed, reasonably readable diff. > > How does one review such a PR in an image, to test it out ? > Has someone written a guide on how to do this best/most-easily ? > How is/can this be related to contributing ? > > Sven > > > > > -- > Pablo Tesone. > [email protected] <mailto:[email protected]>
