another thing I was thinking about is to just do to do “live” youtube sessions…
e.g. if I do a tiny fix, to just stream the whole thing, from start to finish. (but then, I guess the tech talk will be just that) > On 6 Feb 2018, at 13:42, Tim Mackinnon <[email protected]> wrote: > > As an idea - might someone do a tech talk on this and take us through some > scenarios? Every time I think about how to help - I read the pain here and > shy away from it (yes the mental barrier is mine, and also alack of time to > really get to grips with it) - but I was thinking that it someone walked > through it - it might make it all much less scary. > > Tim > > >> On 5 Feb 2018, at 15:57, Sven Van Caekenberghe <[email protected]> wrote: >> >> Ah, Esteban's PR review tool is exactly what I was looking for. It works ! >> >> Still, please, please (Pavel) write down somewhere what you just explained >> to me, else it will eventually be lost. >> >> Docs needed >> >> (1) contribute to Pharo (we have that) >> (2) keep in sync once you have done (1) (we have that, but not about image >> side) >> (3) review pull requests of others (new, this email to start) >> >> Anyway, thanks for the answers. >> >>> On 5 Feb 2018, at 15:10, Pavel Krivanek <[email protected]> wrote: >>> >>> 2018-02-05 13:54 GMT+01:00 Sven Van Caekenberghe <[email protected]>: >>>> Hi, >>>> >>>> With pull requests, it is relatively easy to see what changed in GitHub. >>>> >>>> Eg. Marcus' latest fix: >>>> >>>> https://github.com/pharo-project/pharo/pull/797 >>>> >>>> shows 6 files/classes changed, reasonably readable diff. >>>> >>>> How does one review such a PR in an image, to test it out ? >>> >>> The easiest way is to download an image bootstrapped from that PR. >>> Next to the commits you have a validation status (red cross here), >>> click on it, go to "Artifacts" and then download the image >>> (bootstrap-cache/Pharo7.0-32bit-6ccdd62.zip) >>> >>> Esteban did a Pull request review tool: >>> >>> - register your local Pharo repository copy to Iceberg >>> - in the "Remotes" open context menu on the pharo-project remote (not >>> origin, which is probably our fork) >>> - GitHub - Review pull requests... >>> - open context menu on an issue and select "Review pull request..." >>> - select the newest commit and check changes >>> - to test it locally, do "Merge into image", answer "Yes" >>> >>>> Has someone written a guide on how to do this best/most-easily ? >>> >>> No idea, but Esteban presented that several times on ESUG and other places. >>> >>>> How is/can this be related to contributing ? >>> >>> If you want to use the PR review tool, you should have own fork and >>> local repository - the same for contributing >>> >>> If you then want to propose a modification fo the PR, you already have >>> a branch from the PR merging. >>> - do your change and synchronize the repository so your branch will be >>> present on your fork. >>> - then go to "Remotes" tab, open context menu on "MarcusDenker" remote >>> (it will be created during merging of the PR into your image) and then >>> do pull request. >>> - in Head select your fork and your issue branch name >>> - in Base select Marcus/Denker/pharo and the issue branch name >>> - click on Create Pull request >>> >>> It will create a PR on the repository that Marcus has. Like >>> https://github.com/MarcusDenker/pharo/pull/1 >>> When he will merge it, his PR to on Pharo repository will be updated >>> automatically. >>> >>> Cheers, >>> -- Pavel >>> >>>> >>>> Sven >> >> > >
