Esteban, maybe (until the issue is properly resolved) Iceberg could have a conditional check that the repo is pharo itself and just forced the output to be LF?
Peter On Tue, Apr 10, 2018 at 11:36 PM, Peter Uhnák <[email protected]> wrote: > Hi, > > I --amend(ed) the commit after I converted it. If you've already pushed, > you can force-push (there's no one using your code yet, so forcing > shouldn't be an issue). > If you have multiple commits, then you'd need to filter all the commits > (filter-branch iirc), so the newlines are correct in every single commit. > > Peter > > On Tue, Apr 10, 2018 at 11:31 PM, Nicolai Hess <[email protected]> > wrote: > >> Ah! >> Ok. >> >> 2018-04-10 23:26 GMT+02:00 Peter Uhnák <[email protected]>: >> >>> Hi, >>> >>> did you commit on Windows? Because Iceberg seems to commit in >>> platform-specific line endings, so I always need to convert it manually... >>> ( https://github.com/PowerShell/Win32-OpenSSH/wiki/Dos2Unix- >>> --Text-file-format-converters ) >>> >> >> And how can I do this, if my changes are managed by iceberg ? >> Do I have to manually change the files in my local branch (right at my >> git directory) and can I then still upload the fix from within iceberg? >> >> >>> >>> Notice also that all the files are from the same directory ... when you >>> commit even a single change, the entire package is filed out. >>> >>> Peter >>> >>> >>> >>> >>> On Tue, Apr 10, 2018 at 11:16 PM, Nicolai Hess <[email protected]> >>> wrote: >>> >>>> Hi, >>>> >>>> I tried to create a pull request with IceBerg. >>>> I followed the CONTRIBUTING HowTo and Markus' create TechTalk-Video. >>>> >>>> But I must have done something wrong. >>>> This is my pull request: >>>> https://github.com/pharo-project/pharo/pull/1189 >>>> But although I just changes one line in one method. >>>> The gitub pull request side shows >>>> Commit 1 Files changed 40! >>>> But I did not change 40 files >>>> >>>> >>>> And I still have problems viewing pull requests from within pharo: >>>> >>>> >>>> >>>> >>>> >>>> >>>> I thought this would work meanwhil. >>>> >>>> >>>> Thanks in advance >>>> >>>> nicolai >>>> >>>> >>> >> >
