And this was not just for fun that tests were broken with rubric. First there was no tests when Alain fixed rubric Second some features were bad so not copied and pasted to Rubric.
Life is complex. And we try our best. But I did not want to say to Alain: “too bad you work a lot but now we do not care” because we care a lot about other contributions. Stef > On 2 Apr 2019, at 17:43, Guillermo Polito <guillermopol...@gmail.com> wrote: > > > > On Tue, Apr 2, 2019 at 5:36 PM Marcus Denker <marcus.den...@inria.fr > <mailto:marcus.den...@inria.fr>> wrote: > > > > On 2 Apr 2019, at 17:30, ducasse <steph...@netcourrier.com > > <mailto:steph...@netcourrier.com>> wrote: > > > > Cool and thanks! > > I love this green bar and I will try to keep it green. > > Do you know if the test writing by pierre should be pushed in Pharo because > > I have the impression that they will be red first > > > If we add failing tests, then *everyone* is impacted. Instead of “ah, green” > we will again have to manually check > *every* *single* Pull request. And we, again, will forget to do it. And thus > break even more. > > I really think keeping the tests green is very, very much better for everyone. > > Yes Marcus, but there is another "hidden" point in my mail: my fix was really > simple, anybody could have done it. > So > - just complaining does not fix the build. > - removing breaking tests will not guarantee us a better quality either > > > Marcus > > > > > -- > > Guille Polito > Research Engineer > > Centre de Recherche en Informatique, Signal et Automatique de Lille > CRIStAL - UMR 9189 > French National Center for Scientific Research - http://www.cnrs.fr > <http://www.cnrs.fr/> > > Web: http://guillep.github.io <http://guillep.github.io/> > Phone: +33 06 52 70 66 13
