My bad, meant Polymorph-EventEnhancements. Some more details for those interested (hope I remember correctly this time): The two methods are needed if one wants to be able to use something as argument for the evaluate part of Object when: #XYZ evaluate: myBlock, due to ActionSequence implementation details... For Polymorph, in the createXYZBoxFor: methods in the Vistary themes, addUpAction: does just that with blocks, thus the methods are needed for it.
Cheers, Henry Henrik Johansen wrote: > http://code.google.com/p/pharo/issues/detail?id=337 > > I believe the resolution then was Gary moving the two methods to > Polymorph-Overrides. > Probably some house-cleaning which caused them to be lost this time. > I still stand by my OR: suggestion from back then, isValid is a terrible > method name, imo ;) > > Cheers, > Henry > > Schwab,Wilhelm K wrote: > >> Stef, >> >> Adding #isValid got me a little further along. I was able to select the new >> theme and can at least open a debugger, though _using_ it stirs up trouble >> over #asMinimalRepresentation (or similar method). In trying to evaluate >> 'hello' at:200, I was faced with some message boxes claiming there was no >> such method; that seemed to happen w/ vistary and not watery2??? I too had >> problems closing windows. >> >> Bill >> >> --- >> Wilhelm K. Schwab, Ph.D. >> bschwab AT anest DOT ufl DOT edu >> >> -----Original Message----- >> From: [email protected] >> [mailto:[email protected]] On Behalf Of Stéphane >> Ducasse >> Sent: Sunday, March 22, 2009 1:35 PM >> To: [email protected] >> Cc: Eliot Miranda >> Subject: Re: [Pharo-project] [ANN] Closures for beta testers >> >> >> >>> UIThemeVistary beCurrent. >>> >>> >> what is nice is that the VM does not crash. >> I cannot open any browser. >> So in another image I checked a bit. >> >> BlockContext defined isValid (a polymoprph-EventEnhancements) >> >> sent by >> >> BlockContext>>isValid >> "Answer true so we can be used in event dispatching." >> >> ^true >> >> WeakActionSequence>>asMinimalRepresentation >> >> | valid | >> valid := self select: [:e | e isValid ]. >> valid size = 0 >> ifTrue: [^nil]. >> valid size = 1 >> ifTrue: [^valid first]. >> ^valid >> >> I do not really know the code of gary. >> As a pure hack I added isValid to blockClosure to return true and I did not >> get the problem >> >> of course this is a shitty way to answer the problem. >> >> >> Now when I close using the cross on the right (and not the button on the >> left) the vistaryStyle I get similar problems >> >> [closure] in UIThemeVistary>>createCloseBoxFor: DNU asMinimalRepresentation >> >> >> BlockContext>>asMinimalRepresentation >> "Answer the receiver." >> >> ^self >> >> I defined the same in BlockClosure and it worked but I would prefer to >> understand what I was doing. >> >> >> >> >> stef >> >> >> _______________________________________________ >> Pharo-project mailing list >> [email protected] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> _______________________________________________ >> Pharo-project mailing list >> [email protected] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> >> > > _______________________________________________ > Pharo-project mailing list > [email protected] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ Pharo-project mailing list [email protected] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
