Done and done. I'd rather not make a .cs for the ClosureCompilerTest >>testInjectIntoDecompilations failure though, as I neither feel comfortable messing around with Scanner, nor particularily feel like it would be a good idea to change the test to assume _ instead of := ...
Cheers, Henry Stéphane Ducasse wrote: > excellent!!!! > can you post cs to the Bugtracker so that > we can reload all the fixes in a couple of click? > > http://code.google.com/p/pharo/issues/detail?id=685 > > I'm busy writing something else right now > > Stef > On Mar 23, 2009, at 1:53 PM, Henrik Johansen wrote: > > >> Here's a fix for the BlockContext test. >> Basically, the error message had changed format, so the test that the >> correct error message was reported failed. >> I changed the test to check for the (new) error format (which adds >> argument(s) at the end of the sentence), and changed the error message >> to not call printstring, since this resulted in the string containing >> '1' instead of 1. >> For some reason (which I'm not aware of) the printstring of numbers >> seem >> to include quotes. >> >> On a totally unrelated note, (didn't include it in the cs since it's >> not >> remotely related) >> Debugger contents:notifying contains a call to Smalltalk>> isMorphic >> which should probably be removed, comes up everytime you try to save a >> method edit in the debugger. >> >> Cheers, >> Henry >> >> Stéphane Ducasse wrote: >> >>> I released an archive with two images >>> 10259 with tests run >>> 10259-withClosure + john + lukas + my fixes so far >>> >>> so that we can go faster to fix the problems >>> >>> https://gforge.inria.fr/frs/?group_id=1299 and files >>> >>> Stef >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> [email protected] >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >>> >>> >>> >> 'From Pharo0.1 of 16 May 2008 [Latest update: #10259] on 23 March >> 2009 at 1:47:53 pm'! >> >> !BlockClosure methodsFor: 'error handing' stamp: 'Henrik Sperre >> Johansen 3/23/2009 13:45'! >> numArgsError: numArgsForInvocation >> >> | printNArgs | >> printNArgs := [:n| n printString, ' argument', (n = 1 ifTrue: [''] >> ifFalse:['s'])]. >> self error: >> 'This block accepts ', (printNArgs value: numArgs), >> ', but was called with ', (printNArgs value: >> numArgsForInvocation), '.'! ! >> >> >> !BlockContextTest methodsFor: 'tests - evaluating' stamp: 'Henrik >> Sperre Johansen 3/23/2009 13:45'! >> testValueWithArguments >> self >> should: [aBlockContext >> valueWithArguments: #(1 )] >> raise: Error. >> self >> shouldnt: [aBlockContext >> valueWithArguments: #()] >> raise: Error. >> [aBlockContext >> valueWithArguments: #(1 )] >> ifError: [:err :rcvr | self assert: err = 'Error: This block >> accepts 0 arguments, but was called with 1 argument.']. >> [[:i | 3 + 4] >> valueWithArguments: #(1 2)] >> ifError: [:err :rcvr | self assert: err = 'Error: This block >> accepts 1 argument, but was called with 2 arguments.']! ! >> >> _______________________________________________ >> Pharo-project mailing list >> [email protected] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > _______________________________________________ > Pharo-project mailing list > [email protected] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ Pharo-project mailing list [email protected] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
