Oh, TrascriptStream already uses AccessSema.. So, it should wrap a #changed: with it:
changed: param self semaphore critical: [ super changed: param ] 2009/3/29 Igor Stasenko <[email protected]>: > 2009/3/29 Stéphane Ducasse <[email protected]>: >> Igor >> your change is already in pharo :) >> since months :) > > Yes, but method i changes is not related in particular to Transcript. > The change applies to all users of PluggableTextMorph. > > But as for thread-safe transcript, you need to be careful when you > sending #changed message (each time you printing something - it sends > this message), because it using a notification mechanism to tell > listeners that there is something changed. > Maybe its worth adding #synchronousChanged method to Object > which guards from entry by multiple threads(processes) simueltaneously. > >> Stef >> On Mar 29, 2009, at 6:48 PM, Igor Stasenko wrote: >> >>> 2009/3/29 Stéphane Ducasse <[email protected]>: >>>> did you check what the semaphore critical section is protecting? >>>> cr, tab, nextPutAll: and more and not protected. >>>> >>>> then transcriptStream inherits from stream which is not threadsafe, >>>> so >>>> everything can happen. >>>> I think that having a real thread safe output is a must. >>>> >>> >>> as well as thread-safe updating. >>> Btw, take a look at the http://bugs.squeak.org/view.php?id=7033 >>> >>> The way how Transcript window updates itself is not safe. It should >>> use deferUIMessage to update itself using regular world cycle. >>> >>>> Stef >>>> >>>> On Mar 29, 2009, at 5:55 PM, Keith Hodges wrote: >>>> >>>>> Stéphane Ducasse wrote: >>>>>> Hi >>>>>> >>>>>> I would really like that we get a threadSafeTranscript so I coded >>>>>> one. >>>>>> If you can comment this would help me. >>>>>> >>>>>> Stef >>>>> What is the difference tot he exisitng one, it has an access >>>>> semaphore too. >>>>> >>>>> Keith >>>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> Pharo-project mailing list >>>>> [email protected] >>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>>> >>>> >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> [email protected] >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>> >>> >>> >>> >>> -- >>> Best regards, >>> Igor Stasenko AKA sig. >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> [email protected] >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> >> _______________________________________________ >> Pharo-project mailing list >> [email protected] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > > -- > Best regards, > Igor Stasenko AKA sig. > -- Best regards, Igor Stasenko AKA sig. _______________________________________________ Pharo-project mailing list [email protected] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
