I definitely care about the tests all green ;-) I just don't want to debug into tests when there is no point. I'm not in favour of the wiki idea either. So I'll have a look at expected failures. sounds like we need to mark those two of Lukas' if they are not already
thanks, Mike On Wed, Apr 1, 2009 at 6:29 PM, Adrian Lienhard <[email protected]> wrote: > I would like to see the pattern "all tests always green" (except for > expected failures, see below). Maybe this is too rigorous in practice > since not everybody seems to care that much about tests. It would mean > that no new updates are pushed in the stream until all tests that were > broken by the previous update are fixed. Or even better, we would not > integrate any code as long as it breaks a test. > > Anyway, I see the following two possibilities: > - use SUnit's expected failures feature (see implementors of > #expectedFailures) to marke tests we know are broken > - create a wiki page to document currently broken tests > > I would use the former only for tests that document a bug that we > don't know how to fix within the foreseeable future. The drawback of > the wiki page is that it is prone to get out of date. > > Cheers, > Adrian > > On Apr 1, 2009, at 19:00 , Michael Roberts wrote: > >> It would be good to document this knowledge of what is expected in our >> test suites. Especially if some are known to fail. Is there a pattern >> already in use? >> E.g. Method comment, pragma, wiki page entry? If not what should we >> adopt? >> >> Thanks mike >> >> On 4/1/09, Marcus Denker <[email protected]> wrote: >>> >>> On 01.04.2009, at 11:31, Stéphane Ducasse wrote: >>> >>>> >>>> On Apr 1, 2009, at 11:12 AM, Lukas Renggli wrote: >>>> >>>>>> lukas is it normal that we get 3 tests yellow - did you get the >>>>>> same >>>>>> in your image? >>>>> >>>>> #testToDoOutsideTemp and #testWhileModificationBefore are broken. I >>>>> don't think that should stop us from integrating the closures into >>>>> Pharo. Most "industrial strength" Smalltalk implementations have >>>>> many >>>>> more closure bugs than Pharo. >>>> >>>> This is integrated already and this is good to have such great test >>>> suites. >>>> I will integrate them this evening. >>>> >>> >>> Lukas' teste should be already in, I think. >>> >>> Marcus >>> >>> >>> -- >>> Marcus Denker -- [email protected] >>> http://www.marcusdenker.de >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> [email protected] >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> _______________________________________________ >> Pharo-project mailing list >> [email protected] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > [email protected] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > _______________________________________________ Pharo-project mailing list [email protected] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
