Hi Lukas,
sometime ago I asked which of the RFB/RemoteFrameBuffer versions should
be the one to go for. I choose yours
(http://source.lukar-renggli.ch/unsorted) because the one on squeak
source hasn't had commits (maybe because they were not necessary) but
more importantly, yours has been tailored to Pharo.
I want to make some modifications to the code to better support
configuration of preferences by scripts and not by GUI prompts (I am
working my script to install and configure all I want in a pharo core
image, something like Damien's work, but only with my code and its
dependencies). For this, I want to share the code. Should I upload to
your repo? It is open to upload (I'm almost sure it is)?
Wouldn't be better to copy the RFB code from your repo to the
Pharo/PharoInbox repo given that it will be used heavily with
pharo-web/pharo-dev and more related to pharo than to lukas (I don't
have anything against your repo, in fact it is full of good code, but I
think that the more projects for pharo are stored in the same place, the
better for the final user. Also, I foresee this version as the official
one for pharo, not a version with addons/modifications/hacks for lukas'
servers.
Now the technical:
In RFBServer class side:
shouldConserveMemory
"Answer whether the server should try to conserve memory at all costs."
^true
always returns true. Why?
this is used in the initializePreferences (class side)
self shouldConserveMemory
ifTrue:
[ConserveMemory := true.
EnableDamageFilter := false.
EnableRawFilter := false]
ifFalse:
[ConserveMemory := false.
EnableDamageFilter := true.
EnableRawFilter := true].
to set the class variables and it doesn't permit other behavior.
Shouldn't this be a preference method and when called, assing the
apropriate variables values?
I can't find users of initialize on RFBServer class side. Where it is
called? On loading by Monticello?
What is the difference between names initialise (on instance side) and
initialize (on class side). Is a typo?
I want to make and upload a new version with some modifications. After
review, do you agree to copy them to PharoInbox or do you prefer to have
it in your repo?
Cheers,
Miguel Cobá
_______________________________________________
Pharo-project mailing list
[email protected]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
