Stéphane Ducasse-2 wrote: > > > Use Smalltalk way of formatting code. > > getFiles: aStringPathOfDirectory > > | aFileDirectory fullPathOfFile aCollection | > aFileDirectory := CLFileDirectory on: aStringPathOfDirectory. > aCollection := Bag new. > aFileDirectory fileNames do: > [:nameOfFile | > fullPathOfFile := aFileDirectory fullPathFor: nameOfFile. > aCollection add: fullPathOfFile]. > ^aCollection. > > If you give me access I can reformat everything. > >
Sorry, but i don´t like that format of code. For me is not readable. I don´t know when starts a block or if is a loop or condition block.That problem is more big when exists various identations. I´m coming of VB and C# and that way seems anarchist for me :) my cerebellum is limited for that way of write code. Why my format not is "Smalltalkish" way? Perhaps I´m wrong (i have short time with that language) but I believe indeed than Smalltalk don´t have a style defined (Thanks to God) Stéphane Ducasse-2 wrote: > > > Add some comments. > > In the examples category there is no class comments so I have no idea > about what I'm reading. > > Yes. I´m not add comments basically for my poor english. Today i could try it. Is a relax work for sunday :) Stéphane Ducasse-2 wrote: > > > Nice to see that you use traits :) > > I´m miss it in another languages :) Stéphane Ducasse-2 wrote: > > > Keep working. > I still believe that a windowSpec based on a literal array is better > than a byte array. > > Of course, but I don´t know do it of another way. Literal array is very complicated for me. Xml serialization and Moose serialization don´t be possible. The code generated is HUGE, and fails with complex composite morphs. The one way for me is a mechanism where each morph write his state in a stream. All states togethers will build the final morph. I believe that mechanism works, is elegant and readable. And is easy detect problems too, but i need a little more of time for do it. I want implement various widgets ( a grid is MUCH needed ) and last, before of 1.0 version, the serialization mechanism. Thanks for the feedback :) PS. I added recently the CLSplitterPanel widget -> http://www.youtube.com/watch?v=qbd9bbfxNB4 Regards -- View this message in context: http://n2.nabble.com/Re-feedback-on-CLFramework-tp3718474p3718991.html Sent from the Pharo Smalltalk mailing list archive at Nabble.com. _______________________________________________ Pharo-project mailing list [email protected] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
