On Fri, 15 Jan 2010, Nicolas Cellier wrote:
2010/1/15 Levente Uzonyi <[email protected]>:
On Fri, 15 Jan 2010, Levente Uzonyi wrote:
On Fri, 15 Jan 2010, Mariano Martinez Peck wrote:
Hi: Today Stef and I have being harvested Squeak changes in FileStream. The
most important is the work from Levente and the buffer.
We commit the first slide in inbox: SLICE-FileStream-StephaneDucasse.1
Can someone take a look please because is this quite "important" to
integrate.
StandardFileStream >> #readInto:startingAt:count: is wrong, there's a
newer version. StandardFileStream >> #skip: is missing.
The changes for MultiByteFileStream are also missing. Without those, the
files' state may become corrupt and the expected system-wide speedup will
be less significant.
Changes of classes other than StandardFileStream are unrelated to the read
buffering in the slice.
There's also a new version of StandardFileStream >> #upTo: in the trunk,
which still begs for a cleanup (I wonder who thought that recursion
combined with #, will be fast).
Levente
Yeah, kust peek code in Xtream, it's faster
I'm not about to fix it. The method comment made me think, that #upTo:
is used by #nextChunk, so I added the check for the simple case, but later
realized that #nextChunk doesn't use #upTo:, because it can't, so I just
kept the fallback code. (The bug was unnoticed for more than a month, so I
guess #upTo: is not used at all, I found it while I was reviewing the
code.)
Levente
Nicolas
Levente
Thanks
Mariano
_______________________________________________
Pharo-project mailing list
[email protected]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________
Pharo-project mailing list
[email protected]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________
Pharo-project mailing list
[email protected]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________
Pharo-project mailing list
[email protected]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
