On 10 May 2010 19:26, Nicolas Cellier
<[email protected]> wrote:
> Sorry for the infinite loop, it was my fault.
> I thought it had been detected and solved already (in squeak ?).
>
> Destroying source pointer of un-installed methods was just a
> workaround to be used in case of already broken sources.
> There is another strategy : detect the source pointer of un-installed
> methods and store them in the new change log.
> This has to be done before logging source code of installed methods.
>
I'd like to point, that some trailer kinds don't need to be altered
even if you condensing changes.
They are completely self sufficient and not related to 'standard'
source management system.
In fact, a condense changes _should_ take care only about methods
which having a trailers carrying the source pointers
("001000" #VarLengthSourcePointer, "111111" #SourcePointer ) while
others don't need any changes.
There is a test method in CompiledMethodTrailer, #hasSourcePointer
which can be used to check if you need to deal with this method when
condensing .changes or not.
But since currently the variety of trailers its not widely adopted
(most of methods just storing a source pointers there), its
fine to destroy trailers of non-installed methods. In future, it could
be made more clever.
> Nicolas
>
> 2010/5/9 Igor Stasenko <[email protected]>:
>> On 9 May 2010 23:17, Alain Plantec <[email protected]> wrote:
>>>
>>>> Ok, i took the 11343
>>>> - fixed the #condenseChanges
>>>> - ran Smalltalk condenseChanges
>>>> - changed the single method
>>>> - saved image
>>>> - ran Smalltalk condenseChanges again
>>>>
>>>> no crash reported.
>>>>
>>>
>>> Indeed, with 11343 it seems ok.
>>> With 11326 (updated -> 11346), crash during the second condenseChanges :(
>>
>> Alain, could you please send me an image +.changes saved just before
>> running a second condenseChanges?
>> I'll try to find the cause of it.
>>
>>> Alain
>>>>
>>>>
>>>>>
>>>>> Alain
>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>> _______________________________________________
>>> Pharo-project mailing list
>>> [email protected]
>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>>
>>
>>
>>
>> --
>> Best regards,
>> Igor Stasenko AKA sig.
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [email protected]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
> _______________________________________________
> Pharo-project mailing list
> [email protected]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
--
Best regards,
Igor Stasenko AKA sig.
_______________________________________________
Pharo-project mailing list
[email protected]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
