No, don't waste time on reverting. I almost got it working. My comment was ment for the future :-)
Lukas On 10 December 2010 13:02, Alain Plantec <[email protected]> wrote: > so, concerning the new editor changes, I would like to help because this > messy situation is partly my fault. > would it be helpful if I rename current TextEditor as TextEditor2, (give me > another name please ...), > current SmalltalkEditor as SmalltalkEditor2 and reintroduce the previous > implementation > for TextEditor and SmalltalkEditor ? > Cheers > Alain > > Le 10/12/2010 00:32, Lukas Renggli a écrit : >>> >>> I said it before: just give the variable a different name. For example, >>> textStyle. That would solve all loading problems. >> >> I said it before: This doesn't solve anything at all. In fact it is >> much easier to remove the variable and fork the code. Renaming causes >> a ripple effect to lots of methods and makes it impossible to merge >> the forks in the future. >> >> The style variable is just one example of the problem. I am suggesting >> that the next time the editor framework is replaced the old code is >> left untouched, then deprecated, and different class names are chosen >> for the new implementation. Like this both frameworks can coexist for >> a while making it much easier to migrate the code. >> >> The current situation comes from the fact that some existing classes >> changed their class layout and API completely making migration really >> difficult. >> >> Lukas >> > > > -- Lukas Renggli www.lukas-renggli.ch
