On 28 Jun 2011, at 11:12, Marcus Denker wrote:

> We need to rewrite this:
> 
> InternetConfiguration>>startUp
>       OSPlatform isMacOS ifTrue: [
>               self useHTTPProxy ifTrue: [
>                        (self getHTTPProxyHost findTokens: ':') ifNotEmpty: 
> [:p |
>                               HTTPSocket useProxyServerNamed: p first port: p 
> second asInteger]]]
> 
> For Zinc.

Since (which is now in 1.3 already):

---
Name: Zinc-HTTP-SvenVanCaekenberghe.164
Author: SvenVanCaekenberghe
Time: 17 June 2011, 9:16:22 am
UUID: 90d57d3d-fc41-4548-a2fd-dcd7c22a3a1f
Ancestors: Zinc-HTTP-SvenVanCaekenberghe.163

implemented support for proxies that require authorization;
ZnHeaders class>>#requestHeadersFor: will add a Proxy-Authorization header when 
needed;
added public API ZnNetworkingUtils class>>#proxyAuthorizationHeaderValueToUrl:
removed public API ZnNetworkingUtils class>>#httpProxy and #isProxySet;
upgraded public API ZnNetworkingUtils class>>#shouldProxyUrl: to be a primary 
interface;
refactored internals of ZnNetworkUtils to use NetworkSystemSettings directly 
instead of HTTPSocket;

this code still has to be tested and validated with real world proxies 
---

Zn is no longer using HTTPSocket as authorative source for the proxy settings 
info, but is using NetworkSystemSettings. This was necessary to get the info 
for authenticated proxies. Also, we should not depend on HTTPSocket if we can 
avoid it.

So yes, it seems as if the code that Marcus showed needs to modify 
NetworkSystemSettings, which would fix Mariono's issues.


Sven


Reply via email to