On Tue, Jun 28, 2011 at 12:13 PM, Sven Van Caekenberghe <[email protected]>wrote:
> > On 28 Jun 2011, at 11:12, Marcus Denker wrote: > > > InternetConfiguration>>startUp > > OSPlatform isMacOS ifTrue: [ > > self useHTTPProxy ifTrue: [ > > (self getHTTPProxyHost findTokens: ':') > ifNotEmpty: [:p | > > HTTPSocket useProxyServerNamed: p first > port: p second asInteger]]] > > After browsing the code a bit, adding > > NetworkSystemSettings useHTTPProxy: true > inside the ifNotEmpty: as last statement might already help. > > Thanks Sven, that worked :) Thanks Marcus for pointing us to the right place to fix it. Can we integrate it marcus for 1.3? > It would be cleaner to no longer reference HTTPSocket here and add use > NetworkSystemSettings. The silly thing is that currently, > NetworkSystemSettings itself falls back to HTTPSocket for the proxy host and > port, for backwards compatibility reasons no doubt. Still, the > abstraction/indirection would be good. So then it the code would be > > NetworkSystemSettings > httpProxyServer: p first; > httpProxyPort: p second asInteger; > useHTTPProxy: true > > As sole contents of the ifNotEmpty: > > But since I am not behind a proxy, this must still be tested by someone who > is. > > Regards, > > Sven > > > > -- Mariano http://marianopeck.wordpress.com
