Hi Sven - my suggestion would be to simply put it on the links TestClass, it's 
a minor change that preserves your same flow. 

I had noticed that Stef had a note at this point as he hadn't understood what 
you were trying to convey, and I think this simply sorts it.

I'll try and submit my fork today so you guys can decide. Or you can take the 
other charges. I don't mind, as it's been a great way to get back into pharo.

I just need to get my seaside bit cleared up (which is surprising as I had 
predicted glorp and Postgres would be the stumbling block)

Tim

Sent from my iPhone



Sent from my iPhone
> On 24 May 2017, at 06:22, Sven Van Caekenberghe <s...@stfx.eu> wrote:
> 
> 
>> On 24 May 2017, at 01:36, Tim Mackinnon <tim@testit.works> wrote:
>> 
>> I just forked the booklet today and was working through it. I don’t know if 
>> your changes were already in there, but most things are working for me. I 
>> have hit a few typos and inconsistencies that I’ve noted and I would 
>> recommend a change to the unit test bit as it feels weird to add a test 
>> assert contract method onto the link class (I think its better on the test 
>> class).
> 
> The assert is indeed a bit unconventional but as was explained, it is on 
> purpose / by design. That way it can be shared and used in more places (also 
> outside the unit tests). I would try not to change the actual code to keep 
> the documentation in sync (unless really needed).
> 
>> Tim
>> 
>>>> On 17 May 2017, at 19:03, Sven Van Caekenberghe <s...@stfx.eu> wrote:
>>>> 
>>>> 
>>>> On 17 May 2017, at 19:35, Esteban A. Maringolo <emaring...@gmail.com> 
>>>> wrote:
>>>> 
>>>> 2017-05-17 11:04 GMT-03:00 Sven Van Caekenberghe <s...@stfx.eu>:
>>>>> 
>>>>>> On 17 May 2017, at 16:01, Pierce Ng <pie...@samadhiweb.com> wrote:
>>>>>> 
>>>>>> On Tue, May 16, 2017 at 11:58:50AM +0200, Sven Van Caekenberghe wrote:
>>>>>>> I am bringing my Reddit example back up to date 
>>>>>>> (https://medium.com/concerning-pharo/reddit-st-in-10-cool-pharo-classes-1b5327ca0740)
>>>>>>>  for an upcoming Pharo Booklet.
>>>> 
>>>>>> I've adapted your Reddit application to work with Glorp-SQLite. It was 
>>>>>> pretty
>>>>>> much simply subclassing RedditDatabaseResource and wiring up 
>>>>>> #newGlorpSession.
>>>>>> It's a nice demo of Glorp's pluggability.
>>>>> 
>>>>> That is cool. We should definitively keep a reference to that. Thanks.
>>>> 
>>>> And it's better to get a non devops savvy user to get started, because
>>>> it avoids installing a PgSQL server.
>>> 
>>> Yes and no. 
>>> 
>>> On macOS, http://postgresapp.com is dead simple for any user.
>>> 
>>>> Regards!
>>>> 
>>>> Esteban A. Maringolo
> 
> 


Reply via email to