On Mon Oct 16, 2023 at 2:47 PM CEST, Nia Espera wrote: > Bindings for a charger controller chip found on sm8350 > > Signed-off-by: Nia Espera <nesp...@igalia.com> > --- > include/dt-bindings/iio/qcom,spmi-adc7-smb139x.h | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/include/dt-bindings/iio/qcom,spmi-adc7-smb139x.h > b/include/dt-bindings/iio/qcom,spmi-adc7-smb139x.h > new file mode 100644 > index 000000000000..fe163cd8bbdd > --- /dev/null > +++ b/include/dt-bindings/iio/qcom,spmi-adc7-smb139x.h > @@ -0,0 +1,17 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * Copyright (c) 2020 The Linux Foundation. All rights reserved. > + */ > + > +#ifndef _DT_BINDINGS_QCOM_SPMI_VADC_SMB139X_H > +#define _DT_BINDINGS_QCOM_SPMI_VADC_SMB139X_H > + > +#define SMB139x_1_ADC7_SMB_TEMP (SMB139x_1_SID << 8 | > 0x06) > +#define SMB139x_1_ADC7_ICHG_SMB (SMB139x_1_SID << 8 | > 0x18) > +#define SMB139x_1_ADC7_IIN_SMB (SMB139x_1_SID << 8 | > 0x19) > + > +#define SMB139x_2_ADC7_SMB_TEMP (SMB139x_2_SID << 8 | > 0x06) > +#define SMB139x_2_ADC7_ICHG_SMB (SMB139x_2_SID << 8 | > 0x18) > +#define SMB139x_2_ADC7_IIN_SMB (SMB139x_2_SID << 8 | > 0x19)
I think you should expand qcom,spmi-vadc.h with the 0x06, 0x18 and 0x19, in the ADC7 defines somewhere below ADC7_REF_GND. Regards Luca > + > +#endif
