On Mon, Jan 31, 2011 at 7:59 PM, Suhothayan Sriskandarajah < [email protected]> wrote:
> On 31 January 2011 19:29, Subash Chaturanga <[email protected]> wrote: > > > Hi all, > > > > Last few weeks I was working on two jira issues in photark trunk > > 1.Provide UI support for remote album subscription [1] > > 2.Change local jcr structure in trunk [2] > > > > where I needed to complete the work on jira[2], to finish jira [1] in a > > better way. > > > > I think the above two jira issues are finished and they all work fine > > without any errors. I run it with a cleaned tomcat and worked fine for > me. > > I > > also added client side validations for remote subscriptions.. > > So now, in my patch [3], photark trunk UI supports remote album > > subscription with the new local jcr structure. > > > > The structure is as follows. > > > > Local albums - /albums/local > > Remote Albums - /albums/remote > > > > - I have added a AlbumSubscriptionManager who acquire remote albums from > > corresponding album providers and store them (as Luciano suggested). > > > > - I didn't touch the local gallery service and kept it as it is, and > > created > > a new remote gallery service where it only deals with the remote albums. > > > > - I have added JCRAlbumAggregator, who is capable of aggregating all > types > > of albums.(currently only remote gallery service deals with this, and > local > > gallery service works its own way). > > > > - Above facts make my life easy to change the gallery UI, where local > > albums > > and remote albums works alone separately inside their own html tables. > > > > It will be really feel great for me, if photark can apply this to trunk ( > > if > > this is good enough ) . Please try the patch in your free time and > provide > > any pros and cons of this patch, so that I can make further changes as > > photark needs. > > > > Good job Subash > > Before committing there is a small issue to fix, > After adding picasa album and then when I view the album from the gallery > by pressing the slideshow mode I get an error : > > javax.jcr.PathNotFoundException: BB > at org.apache.jackrabbit.core.NodeImpl.getNode(NodeImpl.java:2683) > at > > org.apache.photark.jcr.services.JCRImageCollectionImpl.get(JCRImageCollectionImpl.java:86) > at sun.reflect.GeneratedMethodAccessor59.invoke(Unknown Source) > at > > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > at java.lang.reflect.Method.invoke(Method.java:597) > at > > org.apache.tuscany.sca.implementation.java.invocation.JavaImplementationInvoker.invoke(JavaImplementationInvoker.java:113) > at > > org.apache.tuscany.sca.binding.http.provider.HTTPBindingListenerServlet.doGet(HTTPBindingListenerServlet.java:104) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:617) > at > > org.apache.tuscany.sca.binding.http.provider.HTTPBindingListenerServlet.service(HTTPBindingListenerServlet.java:72) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:717) > at > > org.apache.tuscany.sca.host.webapp.WebAppRequestDispatcher.forward(WebAppRequestDispatcher.java:110) > at > > org.apache.tuscany.sca.host.webapp.TuscanyServletFilter.doFilter(TuscanyServletFilter.java:94) > at > > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at > > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at > > org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233) > at > > org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191) > at > > org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:465) > at > > org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127) > at > > org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102) > at > > org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) > at > org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:298) > at > org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:852) > at > > org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:588) > at > org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:489) > at java.lang.Thread.run(Thread.java:662) > 31-Jan-2011 19:52:32 > org.apache.tuscany.sca.host.webapp.TuscanyServletFilter > doFilter > SEVERE: null > java.lang.NullPointerException > at > > org.apache.tuscany.sca.binding.http.provider.HTTPBindingListenerServlet.doGet(HTTPBindingListenerServlet.java:141) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:617) > at > > org.apache.tuscany.sca.binding.http.provider.HTTPBindingListenerServlet.service(HTTPBindingListenerServlet.java:72) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:717) > at > > org.apache.tuscany.sca.host.webapp.WebAppRequestDispatcher.forward(WebAppRequestDispatcher.java:110) > at > > org.apache.tuscany.sca.host.webapp.TuscanyServletFilter.doFilter(TuscanyServletFilter.java:94) > at > > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at > > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at > > org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233) > at > > org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191) > at > > org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:465) > at > > org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127) > at > > org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102) > at > > org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) > at > org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:298) > at > org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:852) > at > > org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:588) > at > org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:489) > at java.lang.Thread.run(Thread.java:662) > > > > I think you are calling the old (local album) slide show. Please update > that. > That was the issue and its Done. I have updated the jira. Please find the latest patch in it. Thanks for the feedback. > > Other than that I think its good for the commit > > Thoughts? > > > Suho > > [1] - https://issues.apache.org/jira/browse/PHOTARK-62 > > [2] - https://issues.apache.org/jira/browse/PHOTARK-66 > > [3] - > > > > > https://issues.apache.org/jira/secure/attachment/12469819/uiSubscriptionWithNewStructureCompleted.patch > > > > > > Regards > > /subash > > > -- sk
