On Thu, Jun 19, 2003 at 01:36:26PM +0200, Marcus Börger wrote:
> Hello Thies,
> 
> it would be possible, maybe. But it seems like there are coming more
> changes. Also the current layout is that every handler has it's own .c
> and .h files as well as a generic test. Since you can only have one of
> the db handler the source may be duplicated but only one generates
> code. So i don't think this is anything to worry about.

    i would argue that db4 needs its "own handler" as nobody will
    need a PHP that has both db3 and db4 support. 
    
    two more things: a) i would love to see a *real* sleepycat-db
    interface that exposes all of the db[34] API to PHP (not
    willing to write that myself right now...). but i know that
    that would not belong into the ext/dba abstraction as it
    would have a _lot_ of specialized functions. -and- b) i think
    the current duplication of code is just bloat and thereby bad
    style and should be removed.

    <rant target="_not_ you!"> 
        looking at the pure number of WS and CS commits done by
        various folks i find it really embarrasing that bloat
        like this gets into PHP nearly un-noticed.
    </rant>

    thieso

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to