Hello Thies, Thursday, June 19, 2003, 4:05:58 PM, you wrote:
TCA> On Thu, Jun 19, 2003 at 01:36:26PM +0200, Marcus Börger wrote: >> Hello Thies, >> >> it would be possible, maybe. But it seems like there are coming more >> changes. Also the current layout is that every handler has it's own .c >> and .h files as well as a generic test. Since you can only have one of >> the db handler the source may be duplicated but only one generates >> code. So i don't think this is anything to worry about. TCA> i would argue that db4 needs its "own handler" as nobody will TCA> need a PHP that has both db3 and db4 support. ATM the only thing you can do to support more than one of db2/db3/db4 is to compile them your own and using config "--with-uniquename=NAME" and patch dba accordingly. TCA> two more things: a) i would love to see a *real* sleepycat-db TCA> interface that exposes all of the db[34] API to PHP (not TCA> willing to write that myself right now...). but i know that TCA> that would not belong into the ext/dba abstraction as it TCA> would have a _lot_ of specialized functions. -and- b) i think TCA> the current duplication of code is just bloat and thereby bad TCA> style and should be removed. I played with the stuff today, trying to fix a bug in ext/dba. Yes it would be a nice idea. And yes that would have no longer to do anything with ext/dba. However i don't have the time to write it and anyway that's a thing i would sell so send me customers for it :-) TCA> <rant target="_not_ you!"> TCA> looking at the pure number of WS and CS commits done by TCA> various folks i find it really embarrasing that bloat TCA> like this gets into PHP nearly un-noticed. TCA> </rant> That holds for other parts of php, too. Keeping WS and CS in synch is a good idea to make it easy for all the developers to read the code. And it would even be a better idea to commit only stuff that meets CS. But that's another story. -- Best regards, Marcus mailto:[EMAIL PROTECTED] -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php