Hi Jani,

If we're building PHP under doze we're probably fiddling with src too - it makes sense to have it required for that reason.


- Steph

(you're not allowed a vacation, get back to bugs ;)

----- Original Message ----- From: "Jani Taskinen" <[EMAIL PROTECTED]>
To: "Scott MacVicar" <[EMAIL PROTECTED]>
Cc: <php-cvs@lists.php.net>
Sent: Sunday, March 16, 2008 11:56 PM
Subject: Re: [PHP-CVS] cvs: php-src(PHP_5_3) /win32/build config.w32



Shouldn't this work same way as the other re2c generated stuff, as in: re2c is NOT required since the generated files are there always..? So if re2c is not there -> don't try generating the files, otherwise yes. (I can't check this myself right now, I'm on vacation..;)

--Jani


Scott MacVicar kirjoitti:
scottmac Sun Mar 16 23:54:07 2008 UTC

  Modified files:              (Branch: PHP_5_3)
    /php-src/win32/build config.w32 Log:
  Make re2c required

http://cvs.php.net/viewvc.cgi/php-src/win32/build/config.w32?r1=1.40.2.8.2.10.2.6&r2=1.40.2.8.2.10.2.7&diff_format=u
Index: php-src/win32/build/config.w32
diff -u php-src/win32/build/config.w32:1.40.2.8.2.10.2.6 php-src/win32/build/config.w32:1.40.2.8.2.10.2.7 --- php-src/win32/build/config.w32:1.40.2.8.2.10.2.6 Sun Mar 16 22:26:42 2008
+++ php-src/win32/build/config.w32 Sun Mar 16 23:54:06 2008
@@ -1,5 +1,5 @@
 // vim:ft=javascript
-// $Id: config.w32,v 1.40.2.8.2.10.2.6 2008/03/16 22:26:42 helly Exp $
+// $Id: config.w32,v 1.40.2.8.2.10.2.7 2008/03/16 23:54:06 scottmac Exp $
 // "Master" config file; think of it as a configure.in
 // equivalent.
 @@ -57,7 +57,9 @@
 if (!PATH_PROG('bison')) {
 ERROR('bison is required')
 }
-PATH_PROG('re2c');
+if (!PATH_PROG('re2c')) {
+ ERROR('re2c is required')
+}
 PATH_PROG('zip');
 PATH_PROG('lemon');



--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to