Pierre Joye kirjoitti:
On Mon, Mar 17, 2008 at 5:51 PM, Stanislav Malyshev <[EMAIL PROTECTED]> wrote:

 > If we're building PHP under doze we're probably fiddling with src too -
 > it makes sense to have it required for that reason.

 I do not see any reason to suppose that - no more than building under
 Linux or FreeBSD means that you have changed the source. And since re2c
 is not supplied by any standard packages (cygwin, PHP build zip, etc.)
 and as far as I am aware of no documentation exists on where to find it,
 it would extremely confusing right now for people that just try to
 download and build PHP to actually do it. I think the following should
 be done:

 1. Build should use .c versions without trying to rebuild them each time
 (somehow doesn't work right now)
 2. Configuration should not require re2c installed

(I hate shortcuts in gmail)

There is two scenarii, the releases (snapshots incl.) and build from CVS.

It should be possible to detect if the .c file exist and then call
re2c if not. An additional make rule can also be added to regenerate
the files. We have this exact same problem right now, when a give file
is missing (because bison has not been found), we have a weird
compilation error instead of a nice "xyz is missing and is required to
generate abc".

Would it not better to do it this way?


There is already way to do this properly, we already had 2 (or was it 3?) scanners which require re2c before these 2 new ones, so it should be as easy as doing it the same way for the ini/language scanners too. :)

I'm on vacation right now, and I don't have my "work" laptop with me..otherwise I would have fixed this issue already. ;)


PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to