I would suggest you to revert your patches and commit them when they are ready and tested. For now your patch is just invalid.
Also please run tests on debug build, as it shows some memory corruption errors. ===================================================================== TEST RESULT SUMMARY --------------------------------------------------------------------- Exts skipped : 46 Exts tested : 33 --------------------------------------------------------------------- Number of tests : 7215 6022 Tests skipped : 1193 ( 16.5%) -------- Tests warned : 3 ( 0.0%) ( 0.0%) Tests failed : 73 ( 1.0%) ( 1.2%) Expected fail : 4 ( 0.1%) ( 0.1%) Tests passed : 5942 ( 82.4%) ( 98.7%) --------------------------------------------------------------------- Time taken : 257 seconds ===================================================================== ===================================================================== FAILED TEST SUMMARY --------------------------------------------------------------------- Formatted print functions [tests/strings/002.phpt] Bug #16069 (ICONV transliteration failure) [ext/iconv/tests/bug16069.phpt] iconv stream filter [ext/iconv/tests/iconv_stream_filter.phpt] Persistent connections and mysql.max_persistent [ext/mysql/tests/mysql_pconn_max_links.phpt] mysql_pconnect() - disabling feature [ext/mysql/tests/mysql_pconn_reuse.phpt] Test fscanf() function: usage variations - float formats with resource [ext/standard/tests/file/fscanf_variation10.phpt] Test fscanf() function: usage variations - float formats with arrays [ext/standard/tests/file/fscanf_variation11.phpt] Test fscanf() function: usage variations - float formats with strings [ext/standard/tests/file/fscanf_variation12.phpt] Test fscanf() function: usage variations - float formats with boolean [ext/standard/tests/file/fscanf_variation13.phpt] Test fscanf() function: usage variations - string formats with strings [ext/standard/tests/file/fscanf_variation14.phpt] Test fscanf() function: usage variations - string formats with float values [ext/standard/tests/file/fscanf_variation15.phpt] Test fscanf() function: usage variations - string formats with resource [ext/standard/tests/file/fscanf_variation16.phpt] Test fscanf() function: usage variations - string formats with arrays [ext/standard/tests/file/fscanf_variation17.phpt] Test fscanf() function: usage variations - string formats with integer values [ext/standard/tests/file/fscanf_variation18.phpt] Test fscanf() function: usage variations - string formats with boolean [ext/standard/tests/file/fscanf_variation19.phpt] Test fscanf() function: usage variations - integer formats with integer values [ext/standard/tests/file/fscanf_variation2.phpt] Test fscanf() function: usage variations - char formats with integer values [ext/standard/tests/file/fscanf_variation20.phpt] Test fscanf() function: usage variations - char formats with float values [ext/standard/tests/file/fscanf_variation21.phpt] Test fscanf() function: usage variations - char formats with resource [ext/standard/tests/file/fscanf_variation22.phpt] Test fscanf() function: usage variations - char formats with arrays [ext/standard/tests/file/fscanf_variation23.phpt] Test fscanf() function: usage variations - char formats with strings [ext/standard/tests/file/fscanf_variation24.phpt] Test fscanf() function: usage variations - char formats with boolean [ext/standard/tests/file/fscanf_variation25.phpt] Test fscanf() function: usage variations - char formats with chars [ext/standard/tests/file/fscanf_variation26.phpt] Test fscanf() function: usage variations - octal formats with integer values [ext/standard/tests/file/fscanf_variation27.phpt] Test fscanf() function: usage variations - octal formats with float values [ext/standard/tests/file/fscanf_variation28.phpt] Test fscanf() function: usage variations - octal formats with resource [ext/standard/tests/file/fscanf_variation29.phpt] Test fscanf() function: usage variations - integer formats with float values [ext/standard/tests/file/fscanf_variation3.phpt] Test fscanf() function: usage variations - octal formats with arrays [ext/standard/tests/file/fscanf_variation30.phpt] Test fscanf() function: usage variations - octal formats with strings [ext/standard/tests/file/fscanf_variation31.phpt] Test fscanf() function: usage variations - octal formats with boolean [ext/standard/tests/file/fscanf_variation32.phpt] Test fscanf() function: usage variations - hexa formats with integer values [ext/standard/tests/file/fscanf_variation33.phpt] Test fscanf() function: usage variations - hexa formats with float values [ext/standard/tests/file/fscanf_variation34.phpt] Test fscanf() function: usage variations - hexa formats with resource [ext/standard/tests/file/fscanf_variation35.phpt] Test fscanf() function: usage variations - hexa formats with arrays [ext/standard/tests/file/fscanf_variation36.phpt] Test fscanf() function: usage variations - hexa formats with strings [ext/standard/tests/file/fscanf_variation37.phpt] Test fscanf() function: usage variations - hexa formats with boolean [ext/standard/tests/file/fscanf_variation38.phpt] Test fscanf() function: usage variations - unsigned int formats with integer values [ext/standard/tests/file/fscanf_variation39.phpt] Test fscanf() function: usage variations - integer formats with resource [ext/standard/tests/file/fscanf_variation4.phpt] Test fscanf() function: usage variations - unsigned formats with float values [ext/standard/tests/file/fscanf_variation40.phpt] Test fscanf() function: usage variations - unsigned formats with resource [ext/standard/tests/file/fscanf_variation41.phpt] Test fscanf() function: usage variations - unsigned formats with arrays [ext/standard/tests/file/fscanf_variation42.phpt] Test fscanf() function: usage variations - unsigned formats with strings [ext/standard/tests/file/fscanf_variation43.phpt] Test fscanf() function: usage variations - unsigned formats with boolean [ext/standard/tests/file/fscanf_variation44.phpt] Test fscanf() function: usage variations - scientific formats with integer values [ext/standard/tests/file/fscanf_variation45.phpt] Test fscanf() function: usage variations - scientific formats with float values [ext/standard/tests/file/fscanf_variation46.phpt] Test fscanf() function: usage variations - scientific formats with resource [ext/standard/tests/file/fscanf_variation47.phpt] Test fscanf() function: usage variations - scientific formats with arrays [ext/standard/tests/file/fscanf_variation48.phpt] Test fscanf() function: usage variations - scientific formats with strings [ext/standard/tests/file/fscanf_variation49.phpt] Test fscanf() function: usage variations - integer formats with arrays [ext/standard/tests/file/fscanf_variation5.phpt] Test fscanf() function: usage variations - scientific formats with boolean [ext/standard/tests/file/fscanf_variation50.phpt] Test fscanf() function: usage variations - tracking file pointer while reading [ext/standard/tests/file/fscanf_variation55.phpt] Test fscanf() function: usage variations - integer formats with strings [ext/standard/tests/file/fscanf_variation6.phpt] Test fscanf() function: usage variations - integer formats with boolean [ext/standard/tests/file/fscanf_variation7.phpt] Test fscanf() function: usage variations - float formats with float values [ext/standard/tests/file/fscanf_variation8.phpt] Test fscanf() function: usage variations - float formats with integer values [ext/standard/tests/file/fscanf_variation9.phpt] parse_ini_file() multiple calls [ext/standard/tests/general_functions/parse_ini_file.phpt] Test fprintf() function (variation - 1) [ext/standard/tests/strings/fprintf_variation_001.phpt] Test fprintf() function (variation - 2) [ext/standard/tests/strings/fprintf_variation_002.phpt] Test fprintf() function (variation - 3) [ext/standard/tests/strings/fprintf_variation_003.phpt] Test fprintf() function (variation - 4) [ext/standard/tests/strings/fprintf_variation_004.phpt] Test fprintf() function (variation - 5) [ext/standard/tests/strings/fprintf_variation_005.phpt] Test fprintf() function (variation - 6) [ext/standard/tests/strings/fprintf_variation_006.phpt] Test fprintf() function (variation - 7) [ext/standard/tests/strings/fprintf_variation_007.phpt] Test fprintf() function (variation - 8) [ext/standard/tests/strings/fprintf_variation_008.phpt] Test fprintf() function (variation - 9) [ext/standard/tests/strings/fprintf_variation_009.phpt] htmlentities() test 2 (setlocale / fr_FR.ISO-8859-15) [ext/standard/tests/strings/htmlentities02.phpt] (warn: possibly braindead libc) htmlentities() test 4 (setlocale / ja_JP.EUC-JP) [ext/standard/tests/strings/htmlentities04.phpt] (warn: possibly braindead libc) htmlentities() test 15 (setlocale / KOI8-R) [ext/standard/tests/strings/htmlentities15.phpt] (warn: possibly braindead libc) Test printf() function (32bit) [ext/standard/tests/strings/printf.phpt] Test setlocale() function : usage variations - Setting all available locales in the platform [ext/standard/tests/strings/setlocale_variation2.phpt] Test sprintf() function : error conditions [ext/standard/tests/strings/sprintf_error.phpt] Test vfprintf() function : basic functionality [ext/standard/tests/strings/vfprintf_basic.phpt] Test vfprintf() function : error conditions (wrong argument types) [ext/standard/tests/strings/vfprintf_error3.phpt] Test vfprintf() function : error conditions (various conditions) [ext/standard/tests/strings/vfprintf_error4.phpt] Test vfprintf() function : variation functionality [ext/standard/tests/strings/vfprintf_variation1.phpt] Test vsprintf() function : error conditions [ext/standard/tests/strings/vsprintf_error.phpt] ===================================================================== Thanks. Dmitry David Coallier wrote: > 2008/6/25 Dmitry Stogov <[EMAIL PROTECTED]>: >> David, >> >> Are you going to run "make test" before commits? >> > > I have > >> I see more than 60 new failed tests and some of them show memory corruption. >> "make" doesn't work too, as it crashes during phar.phar build. > > I have ran the tests on standards/tests/strings/ let me run it on the whole > repo > maybe the failing tests are in my skipped tests, can you send me the > list of failing tests? > > I have some failing tests but they are the same that were there before > I applied my patch: > > Test posix_strerror() function : error conditions > [ext/posix/tests/posix_strerror_error.phpt] > Test posix_strerror() function : usage variations > [ext/posix/tests/posix_strerror_variation1.phpt] > Test session_save_path() function : variation > [ext/session/tests/session_save_path_variation5.phpt] > Bug #34657 (If you get a communication problem when loading the WSDL, > it fatal's) [ext/soap/tests/bugs/bug34657.phpt] > Sort with SORT_LOCALE_STRING [ext/standard/tests/array/locale_sort.phpt] > parse_ini_file() multiple calls > [ext/standard/tests/general_functions/parse_ini_file.phpt] > highlight_file() and output buffer [ext/standard/tests/strings/006.phpt] > php_strip_whitespace() and output buffer [ext/standard/tests/strings/007.phpt] > > And from what I see, most of the failing tests are simply outdated > messages but nothing affected by my changes. > > Moreover, phar builds just fine here, have you cvs up'ed? what OS are you on? > >> Also why don't you commit to HEAD? > > Haven't you noticed that I am not the only one not committing to HEAD? > We are doing this for the 5_3 release since this is the most realistic > and close one from now. I agree that it HEAD should be kept to date > but if you are to pick on me, pick on everyone who is doing this > zend-parse-parameter cleanup move please. This is not the first commit > related to the cleanup. > > > So just send me a list of your failing tests (offlist presumably) > Thanks, > -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
