On Thu, Jul 3, 2008 at 4:23 PM, Derick Rethans <[EMAIL PROTECTED]> wrote:
> On Thu, 3 Jul 2008, Pierre-Alain Joye wrote:
>
>> pajoye                Thu Jul  3 13:50:15 2008 UTC
>>
>>   Modified files:              (Branch: PHP_5_3)
>>     /php-src/ext/mcrypt       mcrypt.c php_mcrypt.h
>>     /php-src/ext/mcrypt/tests bug35496.phpt bug41252.phpt bug43143.phpt
>>                               mcrypt_cbc.phpt mcrypt_cbf.phpt
>>                               mcrypt_decrypt.phpt
>>   Log:
>>   - fix mcrypt_iv on windows, use urandom equivalent
>>   - MFH, code cleaning and reorganisation
>
> WTF, you mentioned that you'd be doing this, and I agreed to a patch
> that you showed for it. You *NEVER* mentioned anything of touching every
> single line of this code. There is 1. no good reason, 2.
> you should discuss that with the maintainer and 3. NEVER mix code and
> whitespace changes. Revert this patch, now.

You gave me your OK to MFH the cleanup code from HEAD.

I see no reason to revert this commit now, why do you want me to
revert it except for making my work harder?


Cheers,
-- 
Pierre
http://blog.thepimp.net | http://www.libgd.org

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to