2009/5/5 Jani Taskinen <jani.taski...@sci.fi>:
> Kalle Sommer Nielsen kirjoitti:
>>
>> 2009/5/5 Jani Taskinen <j...@php.net>:
>>>
>>> jani            Tue May  5 01:22:31 2009 UTC
>>>
>>>  Modified files:
>>>   /php-src/ext/imap   config.m4 php_imap.c php_imap.h
>>>  Log:
>>>  - Fix build (modified utf7 stuff is rather new..)
>>>
>>
>> No AC_DEFINE()'s to config.w32? So its no disabled on Windows, in
>> future please remember such things, as it was the reason for
>> socket_create_pair() not being available on Windows from 4.3 to 5.3 by
>> such a change by you.
>
> Whatta hell are you talking about? That's windows. It's controlled build and
> I don't know how to add any tests in that crap..

What I was talking about ext/sockets, was that you changed a check to
see if it was available on the host system or not which is fair
enough, but never added an AC_DEFINE() to config.w32, so it was
disabled:
http://cvs.php.net/viewvc.cgi/php-src/ext/sockets/sockets.c?r1=1.190&r2=1.191

And you're fix to config.w32 makes the mutf7 <> utf8 functions work again.

>
> --Jani
>
>



-- 
Kalle Sommer Nielsen
ka...@php.net

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to