Hi Tony,

Thanks, comments below...

----- Original Message -----
From: "Antony Dovgal"
Sent: Friday, June 05, 2009

On 04.06.2009 22:18, Matt Wilmas wrote:
mattwil Thu Jun  4 18:18:47 2009 UTC

New failed tests:

ext/standard/tests/array/array_slice_variation2.phpt
ext/standard/tests/array/array_slice_variation3.phpt
ext/standard/tests/math/decbin_variation1_64bit.phpt
ext/standard/tests/math/dechex_variation1_64bit.phpt
ext/standard/tests/math/decoct_variation1_64bit.phpt

Made a couple mistakes there with my guessing for the 64-bit tests...

array_slice2/3 are 32-/64-bit only, respectively, in 5.2 though they're testing different things. Hmm. Well, I changed them to match 5.2.

ext/standard/tests/strings/chunk_split_variation2.phpt
ext/standard/tests/strings/chunk_split_variation5.phpt
ext/standard/tests/strings/chunk_split_variation8.phpt

It looks like these should also be failing with 5.2 on 64-bit? I'll leave them as-is for now then... Some options:

Skip them on 64-bit? variation2 could have a 64-bit version added. variation5/8 look like the same thing (and don't get why they reference Bug #42796). Their logic for the test value (PHP_INT_MAX * 3) is flawed anyway with the old (err, formerly new) double->long conversion method, but that could be changed to get the same result cross-platform...

--
Wbr,
Antony Dovgal

- Matt

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to