Pierre, Pierre,
+ if (SSL_CTX_use_PrivateKey_file(ctx, resolved_path_buff,
SSL_FILETYPE_PEM) != 1) {
this is what the revert gives back, if you go and check what this
function does:
"The SSL_CTX_use_PrivateKey_file function loads the private key for use
with Secure Sockets Layer (SSL) sessions using a specific context (CTX)
structure."
However, what gets passed is path to a certificate, not to a private
key. So you reintroduce a bug, that is.
And locally I reverted the patch that was reverting my changes, thus
introducing them again, and I got :
Number of tests : 41 38
Tests skipped : 3 ( 7.3%) --------
Tests warned : 0 ( 0.0%) ( 0.0%)
Tests failed : 0 ( 0.0%) ( 0.0%)
Expected fail : 0 ( 0.0%) ( 0.0%)
Tests passed : 38 ( 92.7%) (100.0%)
---------------------------------------------------------------------
Time taken : 3 seconds
=====================================================================
So, I am going to revert the revert and reintroduce the code that fixes
a bug.
Have a nice day!
Andrey
Pierre Joye wrote:
hi,
On Fri, Apr 23, 2010 at 12:14 PM, Andrey Hristov <p...@hristov.com> wrote:
More info about the segfaults? Tests that show the segfaults and thus keep
us from regressions?
The tests we have in ext/openssl/tests crash.
However we were wondering why you did these changes and I did not see
any relation between the commit msg and this change. If there is a bug
in this code, please provide a reproduce case and a patch so we can be
sure it won't break ssl functions.
Cheers,
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
