On Fri, 2010-04-23 at 13:05 +0200, Andrey Hristov wrote:
> Pierre, Pierre,
> +     if (SSL_CTX_use_PrivateKey_file(ctx, resolved_path_buff, 
> SSL_FILETYPE_PEM) != 1) {
> 
> this is what the revert gives back, if you go and check what this 
> function does:
> 
> "The SSL_CTX_use_PrivateKey_file function loads the private key for use 
> with Secure Sockets Layer (SSL) sessions using a specific context (CTX) 
> structure."
> 
> However, what gets passed is path to a certificate, not to a private 
> key. So you reintroduce a bug, that is.
> 
> And locally I reverted the patch that was reverting my changes, thus 
> introducing them again, and I got :
> Number of tests :   41                38
> Tests skipped   :    3 (  7.3%) --------
> Tests warned    :    0 (  0.0%) (  0.0%)
> Tests failed    :    0 (  0.0%) (  0.0%)
> Expected fail   :    0 (  0.0%) (  0.0%)
> Tests passed    :   38 ( 92.7%) (100.0%)
> ---------------------------------------------------------------------
> Time taken      :    3 seconds
> =====================================================================

The interesting question is: What's the difference between the systems?
Andrey's system doesn't show an issue, gcov's last run was fine
http://gcov.php.net/viewer.php?version=PHP_5_3&func=tests (ok, this is
5.3, but I don't see difference between trunk and 5.3)

What openssl versions yre you using? Any "special" compiler flags?

The patch itself is needed to so login using SSL certificate to an MySQL
server works under mysqlnd.

Maybe somebody who can reproduce the crash could take a deeper look
what's wrong?

thanks,
johannes



-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to