On Tue, 21 Dec 2010 18:52:07 -0000, Christopher Jones <christopher.jo...@oracle.com> wrote:




On 12/21/2010 10:47 AM, Gustavo Lopes wrote:
On Tue, 21 Dec 2010 18:23:11 -0000, Christopher Jones <christopher.jo...@oracle.com> wrote:


Hi Gustavo,

Can you review the definition of http://www.php.net/manual/en/splminheap.compare.php ? I believe the testcase should have the operands reversed to satisfy this definition and so the bug was bogus.


I did. The definition says compare() should give a positive number if $value1 is larger than $value2, which it does:

That's the definition for SplMaxHeap.  The definition for SplMinHeap
is "positive integer if value1 is lower than value2".  See the link
above.


Oops. You're right. I've reversed the change and closed the bug as bogus.

Thanks.

--
Gustavo Lopes


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to