On Tue, Feb 15, 2011 at 10:17 AM, Dmitry Stogov <dmi...@zend.com> wrote: > Hi Pierre, > > The check for (byte_count_signed > 2147483648) looks ugly and it's even > wrong.
It is not ugly nor wrong. See my post in when I proposed the patch. It should actually be something much lower but I did not find a reliable reference for this value (max length of a tag value). > It should be changed to something like (byte_count_signed > INT32_MAX) where > INT32_MAX = 0x7fffffff (or 2147483647). Yes, using a constant could be nice, I will check if that one is actually always available. Cheers, -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
![Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/exif/exif.c branches/PHP_5_3/ext/exif/tests/bug54002.phpt branches/PHP_5_3/ext/exif/tests/bug54002_1.jpeg branches/PHP_5_3/ext/exif/tests/bug54002_2.jpeg trunk/ext/exif/exif.c trunk/ext/exif/tests](/search?l=php-cvs@lists.php.net&q=subject:%22Re%5C%3A+%5C%5BPHP%5C-CVS%5C%5D+svn%5C%3A+%5C%2Fphp%5C%2Fphp%5C-src%5C%2F+branches%5C%2FPHP_5_3%5C%2Fext%5C%2Fexif%5C%2Fexif.c+branches%5C%2FPHP_5_3%5C%2Fext%5C%2Fexif%5C%2Ftests%5C%2Fbug54002.phpt+branches%5C%2FPHP_5_3%5C%2Fext%5C%2Fexif%5C%2Ftests%5C%2Fbug54002_1.jpeg+branches%5C%2FPHP_5_3%5C%2Fext%5C%2Fexif%5C%2Ftests%5C%2Fbug54002_2.jpeg+trunk%5C%2Fext%5C%2Fexif%5C%2Fexif.c+trunk%5C%2Fext%5C%2Fexif%5C%2Ftests%22&o=newest){kind=link}
