Am 19.09.2011 11:57, schrieb Ferenc Kovacs:
On Mon, Sep 19, 2011 at 10:19 AM, Ulf Wendel<ulf.wen...@oracle.com>  wrote:
Am 17.09.2011 05:12, schrieb Xinchen Hui:

laruence                                 Sat, 17 Sep 2011 03:12:23 +0000

Revision: http://svn.php.net/viewvc?view=revision&revision=316895

Log:
Fix Bug #55703(PHP crash when calling mysqli_fetch_fields)
Since the catalog values always is "def" now, see
http://dev.mysql.com/doc/refman/5.0/en/c-api-data-structures.html

Bug: https://bugs.php.net/55703 (Duplicate) PHP crash when calling
mysqli_fetch_fields

Ideally, you would wait for a libmysql fix, after the fix add a version
change and revert. What if libmysql decides to set a value in the future?
What about people who still use MySQL 4.1.0 ?


uhm, 4.1 is EOLed for some time by now, why should we care about such
an old version?
http://www.mysql.com/support/eol-notice.html

Good point, are you proposing to change code and make libmysql 5.0+ a requirement? If so, several changes should be made to ext/mysql, ext/mysqli and PDO_MySQL.

Ulf

nixnutz@linux-fuxh:~/php/php-src/branches/PHP_5_4> grep -H -n -R MYSQL_VERSION_ID ext/mysqli/*.c
[snip]
ext/mysqli/mysqli.c:611:#if MYSQL_VERSION_ID >= 40000
[snip]
ext/mysqli/mysqli.c:854:#if MYSQL_VERSION_ID >= 40000
ext/mysqli/mysqli.c:886:#if !defined(MYSQLI_USE_MYSQLND) && defined(ZTS) && MYSQL_VERSION_ID >= 40000 ext/mysqli/mysqli.c:924:#if !defined(MYSQLI_USE_MYSQLND) && defined(ZTS) && MYSQL_VERSION_ID >= 40000

nixnutz@linux-fuxh:~/php/php-src/branches/PHP_5_4> grep -H -n -R MYSQL_VERSION_ID ext/mysql/*.c ext/mysql/php_mysql.c:82:#if MYSQL_VERSION_ID > 32199 || defined(MYSQL_USE_MYSQLND) ext/mysql/php_mysql.c:92:#if MYSQL_VERSION_ID >= 32032 || defined(MYSQL_USE_MYSQLND) ext/mysql/php_mysql.c:96:#if MYSQL_VERSION_ID > 32133 || defined(FIELD_TYPE_TINY)
ext/mysql/php_mysql.c:100:#if MYSQL_VERSION_ID >= 32200
ext/mysql/php_mysql.c:111:#if MYSQL_VERSION_ID < 32224
ext/mysql/php_mysql.c:129:#if MYSQL_VERSION_ID >= 40101
ext/mysql/php_mysql.c:247:#if MYSQL_VERSION_ID < 40000
ext/mysql/php_mysql.c:308:#if MYSQL_VERSION_ID < 40000
ext/mysql/php_mysql.c:571:#if MYSQL_VERSION_ID >= 40000
ext/mysql/php_mysql.c:578:#if MYSQL_VERSION_ID >= 40000
ext/mysql/php_mysql.c:598:#if MYSQL_VERSION_ID >= 40000
ext/mysql/php_mysql.c:623:#if !defined(MYSQL_USE_MYSQLND) && defined(ZTS) && MYSQL_VERSION_ID >= 40000 ext/mysql/php_mysql.c:655:#if !defined(MYSQL_USE_MYSQLND) && defined(ZTS) && MYSQL_VERSION_ID >= 40000
ext/mysql/php_mysql.c:727:#if MYSQL_VERSION_ID <= 32230
ext/mysql/php_mysql.c:734: if ((MYSQL_VERSION_ID / 100) != (mysql_get_client_version() / 100)) { ext/mysql/php_mysql.c:737: MYSQL_VERSION_ID, mysql_get_client_version());
ext/mysql/php_mysql.c:836:#if MYSQL_VERSION_ID < 32200
ext/mysql/php_mysql.c:1375:#if MYSQL_VERSION_ID < 40000
ext/mysql/php_mysql.c:1487:#if MYSQL_VERSION_ID > 32199

nixnutz@linux-fuxh:~/php/php-src/branches/PHP_5_4> grep -H -n -R MYSQL_VERSION_ID ext/pdo_mysql/*.c ext/pdo_mysql/mysql_driver.c:330:#if MYSQL_VERSION_ID >= 40100 || defined(PDO_USE_MYSQLND) ext/pdo_mysql/mysql_driver.c:342:#if MYSQL_VERSION_ID >= 40100 || defined(PDO_USE_MYSQLND) ext/pdo_mysql/mysql_driver.c:356:#if MYSQL_VERSION_ID >= 40100 || defined(PDO_USE_MYSQLND)
ext/pdo_mysql/mysql_driver.c:481:#if MYSQL_VERSION_ID <= 32230
ext/pdo_mysql/mysql_driver.c:489:#if MYSQL_VERSION_ID > 32230



--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to