On Thu, Feb 08, 2001 at 03:45:33PM +0200, Zeev Suraski wrote:

> > >First of all, it definitely matters.  Sending the right value is extremely
> > >important.  If you send 1 instead of 0, then you would get a memory
> > >leak.  If you send a 0 instead of 1, you'll most likely crash.  So you
> > >really must send the right values each time :)
> > > [...]
> >
> >So what you're saying is
> >- if duplicate is set to 0, you create a reference
> >- if duplicate is set to 1, you increase the reference counter
> >so that 'duplicate' means 'I am a duplicate', instead of what I first
> >thought 'duplicate me' (which is why I sent a 1 first (duplicate me), and a
> >0 second).
> 
> No, it's not clear I guess :)
> 
> 'duplicate' does mean 'duplicate me'.
> If duplicate is set to 0, then you tell the engine not to duplicate the 
> string, but use it as-is.  If it's set to 1, then you tell the engine to 
> duplicate it, because this string is either static, or already referenced 
> by other things in PHP.

Perhaps 0 and 1 should be replaced by more verbose #define's
(constants) to make this code clearer, then.

-- 
Jon Parise ([EMAIL PROTECTED])  .  Rochester Inst. of Technology
http://www.csh.rit.edu/~jon/  :  Computer Science House Member

-- 
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

Reply via email to