> [EMAIL PROTECTED] wrote:
>> This sort of bothers me. Who is this "our" you talk about? As
>> contributor of the msession extension, am I not also part of "our"
>> and don't I get a say on the priorities of msession?
>
> not if these priorities are in contradiction to the overall goals, and
> as such BC is not *that* important on a developement branch
Perhaps, but it is not "contrary" either.
>
>> I can understand your position, but the msession extension not a
>> difficult peice of code. I have updated the proto comments so they
>> correctly state what the functions do. Just tell me what else you
>> want for comments.
>
> the #ifdef OLD_ZEND_PARAM stuff obfuscates it without need,
> especially in the additional places where you use it like this
>
> #ifdef OLD_ZEND_PARAM
> php_log_err("Call to connect with non-null s_conn");
> #else
> php_log_err("Call to connect with non-null s_conn" TSRMLS_CC);
> #endif
>
> the behaviour you test for is not at all related to the parameter
> parsing functions, its just by coincidence that both are related
> to the same api version number switch
What's a better test?
--
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php
