At 17:43 12/05/2002, Sascha Schumann wrote:
>     I've just noticed that you have kicked out the premier
>     implementation of the same functionality in favor of the dog
>     slow old one.

I almost missed those idyllic descriptions :)

>     Note that relying on output buffering alone is inferior,
>     because (a) it is not always enabled

It can be enabled for this purpose alone, if you think it's that much of an 
issue (I don't, but I don't mind doing that either).

>  and (b) it does not
>     address the inherent flaws in the zend implementation.

What inherent flaws?  So far, the only difference between them that I could 
spot was that php_html_puts() was buggy, and did not convert series of 
spaces into  's.  Otherwise, the only difference was the use of 
buffering.  I may have missed something, though.

>     I suggest reverting that commit and doing whatever is
>     necessary to improve the zend implementation.
>
>     This could be achieved by defining a function pointer
>     zend_html_puts with the same parameters as php_html_puts and
>     let applications set that function pointer.  The default
>     could continue to point to the current zend_html_puts code.

I don't see why it's necessary.  If you think buffering phpinfo() is really 
necessary, then we can enable buffering for it.

Zeev


-- 
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to