At 18:34 12/05/2002, Sascha Schumann wrote:
>     I favor php_html_puts also due to maintability reasons.
>     Please consider this part of code from zend_html_puts:
>
>             && !(((ptr+1)>=end) || (*(ptr+1)==' ')) /* next is not a space */
>             && !((ptr==s) || (*(ptr-1)==' '))) /* last is not a space */ {
>
>     And contrast it with the inherent beauty of php_html_puts.

Ok, so I'll use your method.  By the way, there was nothing inherent in the 
two places you used 'inherent', on this topic :)

> > I'd *really* like to avoid having two copies of the same code,
> > though.  Please remove the duplicated implementation...
>
>     Ok, I'll implement the solution I posted earlier and make
>     zend_html_puts a function pointer.

Again, I fail to understand the logic behind it.  I'll change the space 
handling code to your method (which is indeed nicer);  Why on earth would 
we need to have a stupid HTML printout function as a function pointer?


-- 
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to